Skip to content
This repository has been archived by the owner on Apr 26, 2021. It is now read-only.

Adding limit to total size of uploaded files from analysis #3169

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cccs-kevin
Copy link

Thanks for contributing! But first: did you read our community guidelines?
https://cuckoo.sh/docs/introduction/community.html

What I have added/changed is:

If you pass max_total_size_of_uploaded_files=[0|int>0] as a task option, the analyzer will only upload files from analysis up until the total size of these files could exceed the limit.

The goal of my change is:

There are samples such as this that behave in such a way that the Cuckoo analyzer ends up uploading ~1.3Gb of files and ~2.8Gb of logs to the resultserver, which may cause issues depending on how you are using Cuckoo's analysis post-analysis (ex. Using the REST API to retrieve a tarball that contains all of this!💀). Therefore, I propose that there should be an option to limit the total size of files that are to be uploaded from analysis.

What I have tested about my change is:

Manual testing.

Let me know what you think!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant